feat: Update to listener v1.4.0 and remove Owner field usage #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
medmes
force-pushed
the
remove-owner-field-runtime-watcher
branch
from
d6de45a to
c6b0185
Compare
Member
Author
|
Note to reviewer This PR depends on kyma-project/lifecycle-manager#2961 being merged to main first. Once PR #2961 is merged to main, please rerun the watcher enqueue e2e test so it will run against the KLM image built from the main branch (which will include listener v1.4.0 support). |
- Update listener dependency from v1.3.0 to v1.4.0 - Remove Owner field from WatchEvent construction - Remove extractOwner() function and related code - Remove ownedBy annotation constant (no longer needed) - Remove errNoOwner error - Remove ReasonOwner metric constant - Remove e2e test for owner annotation validation This completes the removal of the deprecated Owner field from runtime-watcher. The Owner field was removed from listener in v1.4.0 as part of architecture refactoring. Part of kyma-project#549
medmes
force-pushed
the
remove-owner-field-runtime-watcher
branch
from
c6b0185 to
db466af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes the removal of the deprecated Owner field from runtime-watcher. The
Ownerfield was removed from listener inv1.4.0as part of architecture refactoring.Changes proposed in this pull request:
Ownerfield fromWatchEventconstructionextractOwner()function and related codeownedByannotation constant (no longer needed)errNoOwnererrorReasonOwnermetric constantRelated issue(s)
#549