Skip to content

Comments

Bump lodash and cmake-js#4

Open
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/lodash-and-cmake-js-4.17.21
Open

Bump lodash and cmake-js#4
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/lodash-and-cmake-js-4.17.21

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Apr 19, 2023

Bumps lodash to 4.17.21 and updates ancestor dependency cmake-js. These dependencies need to be updated together.

Updates lodash from 4.17.4 to 4.17.21

Commits
  • f299b52 Bump to v4.17.21
  • c4847eb Improve performance of toNumber, trim and trimEnd on large input strings
  • 3469357 Prevent command injection through _.template's variable option
  • ded9bc6 Bump to v4.17.20.
  • 63150ef Documentation fixes.
  • 00f0f62 test.js: Remove trailing comma.
  • 846e434 Temporarily use a custom fork of lodash-cli.
  • 5d046f3 Re-enable Travis tests on 4.17 branch.
  • aa816b3 Remove /npm-package.
  • d7fbc52 Bump to v4.17.19
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by bnjmnt4n, a new releaser for lodash since your current version.


Updates cmake-js from 3.5.0 to 7.2.1

Release notes

Sourced from cmake-js's releases.

v7.0.0

This is a breaking change and will likely require some small changes to your cmake config to keep your project building.

Summary

A lot of work has gone into this release, to try and make the general usage of the library smoother. It has better support for building modules with node-api. The on disk footprint of the library is much smaller than before, with various dependencies removed, or updated.

Upgrading

We recommend having the following at the top of your cmake file, before the project(...) definition.

cmake_minimum_required(VERSION 3.15)
cmake_policy(SET CMP0091 NEW)
cmake_policy(SET CMP0042 NEW)

This will force MSVC to do a MT build, so if you were doing that another way, it should be possible to remove that. If you need to keep it building as MD, you can add set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL") in your cmake file.

If you are using node-api, make sure that your package.json has the following, but with the correct NAPI_VERSION filled in. We use this to autodetect that your module is building with node-api.

"binary": {
    "napi_versions": [7]
  },

You should also add the following to the bottom of your cmake file. This lets us avoid downloading the full nodejs headers, and lets us use bundle a much more lightweight copy instead

if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
  # Generate node.lib
  execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
endif()

If you have something like:

execute_process(COMMAND node -p "require('node-addon-api').include"
        WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
        OUTPUT_VARIABLE NODE_ADDON_API_DIR
        )
string(REPLACE "\n" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
string(REPLACE "\"" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
target_include_directories(${PROJECT_NAME} PRIVATE ${NODE_ADDON_API_DIR})

in your file, it is no longer needed. We will inject the correct include paths for you, similar to what is done for nan.

That should be everything.
If we missed something in these steps, or if you are having problems getting your module building again, let us know in an issue.

All changes:

  • update dependencies
  • replace some dependencies with modern language features

... (truncated)

Changelog

Sourced from cmake-js's changelog.

v7.2.1 - 14/02/23

  • fix: support Windows11SDK

v7.2.0 - 12/02/23

  • fix: -DCMAKE_JS_VERSION=undefined (#298)
  • fix: Only add build type to CMAKE_LIBRARY_OUTPUT_DIRECTORY if needed (#299)
  • feat: Forward extra arguments to CMake commands (#297)

v7.1.1 - 15/12/22

  • fix build errors on windows

v7.1.0 - 14/12/22

  • add commands for retrieving cmake-js include and lib directories
  • fix win delay hook issues with electron
  • fix missing js_native_api_symbols in windows node.lib

v7.0.0 - 08/10/22

  • update dependencies
  • replace some dependencies with modern language features
  • follow node-gyp behaviour for visual-studio version detection and selection
  • automatically locate node-addon-api and add to include paths
  • avoid downloads when building for node-api
  • encourage use of MT builds with MSVC, rather than MD

v6.3.1 - 05/06/22

  • add missing bluebird dependency
  • fix platform detection for visual studio 2019 and newer
  • fix platform detection for macos

v6.3.0 - 26/11/21

v6.2.1 - 20/07/21

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by julusian, a new releaser for cmake-js since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [lodash](https://github.com/lodash/lodash) to 4.17.21 and updates ancestor dependency [cmake-js](https://github.com/cmake-js/cmake-js). These dependencies need to be updated together.


Updates `lodash` from 4.17.4 to 4.17.21
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.21)

Updates `cmake-js` from 3.5.0 to 7.2.1
- [Release notes](https://github.com/cmake-js/cmake-js/releases)
- [Changelog](https://github.com/cmake-js/cmake-js/blob/master/changelog.md)
- [Commits](https://github.com/cmake-js/cmake-js/commits/v7.2.1)

---
updated-dependencies:
- dependency-name: lodash
  dependency-type: indirect
- dependency-name: cmake-js
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants