chore(release): rebrand changelog authors heading to skull#291
Merged
Conversation
laazyj
force-pushed
the
chore/skull-changelog-authors
branch
from
July 9, 2026 15:44
71f75e5 to
aad47c0
Compare
Contributor
CoverageOverall line coverage: 99.29% across 21 package(s).
|
nx's DefaultChangelogRenderer hardcodes the "❤️ Thank You" authors heading. Point release.changelog.workspaceChangelog.renderer at a thin subclass that overrides renderAuthors() to swap the heart for the skull mark from jasonduffett.net, inheriting all other rendering so upstream changelog changes still flow through on nx upgrades. The renderer is CommonJS (.cjs) because nx loads non-".ts" renderer paths with require(), which cannot import an ESM module in this "type": "module" workspace. Scope an eslint block to scripts/*.cjs so require()/module.exports lint cleanly there without relaxing the CommonJS ban anywhere else. Cosmetic only; applies to future `nx release changelog` runs. Existing CHANGELOG.md entries are unchanged. Preview with `npm run release:dryrun`.
laazyj
force-pushed
the
chore/skull-changelog-authors
branch
from
July 10, 2026 09:05
aad47c0 to
8d44942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nx's built-in
DefaultChangelogRendererhardcodes the authors section heading as### ❤️ Thank You— there's no config option to change just the emoji. This pointsrelease.changelog.workspaceChangelog.rendererat a thin subclass that overridesrenderAuthors()to swap the heart for the 💀 mark from jasonduffett.net, inheriting everything else so upstream changelog changes still flow through on nx upgrades.Changes
scripts/changelog-renderer.cjs— subclass of nx'sDefaultChangelogRenderer; only the authors heading is rewritten.nx.json—workspaceChangelogexpands fromtrueto{ renderer: … }. All other changelog defaults (output file, etc.) are unchanged.eslint.config.mjs— scope a block toscripts/*.cjssorequire()/module.exportslint cleanly there. The CommonJS ban stays on everywhere else.Why
.cjsnx loads non-
.tsrenderer paths withrequire(), which can't import an ESM module — and this workspace is"type": "module", so a.js/.mjsrenderer would be ESM..cjsis the format nx's loader can consume here. (A.tsrenderer would avoid the eslint scoping but would be the only TypeScript file underscripts/, which is otherwise all plain.mjs.)Verification
Previewed against current git history via
npm run release:dryrun(the changelog path only) — output renders### 💀 Thank You. Cosmetic only: applies to futurenx release changelogruns; existingCHANGELOG.mdentries are untouched.🤖 Generated with Claude Code