Skip to content

chore(release): rebrand changelog authors heading to skull#291

Merged
laazyj merged 1 commit into
mainfrom
chore/skull-changelog-authors
Jul 10, 2026
Merged

chore(release): rebrand changelog authors heading to skull#291
laazyj merged 1 commit into
mainfrom
chore/skull-changelog-authors

Conversation

@laazyj

@laazyj laazyj commented Jul 9, 2026

Copy link
Copy Markdown
Owner

What

nx's built-in DefaultChangelogRenderer hardcodes the authors section heading as ### ❤️ Thank You — there's no config option to change just the emoji. This points release.changelog.workspaceChangelog.renderer at a thin subclass that overrides renderAuthors() to swap the heart for the 💀 mark from jasonduffett.net, inheriting everything else so upstream changelog changes still flow through on nx upgrades.

### 💀 Thank You

- Jason Duffett

Changes

  • scripts/changelog-renderer.cjs — subclass of nx's DefaultChangelogRenderer; only the authors heading is rewritten.
  • nx.jsonworkspaceChangelog expands from true to { renderer: … }. All other changelog defaults (output file, etc.) are unchanged.
  • eslint.config.mjs — scope a block to scripts/*.cjs so require()/module.exports lint cleanly there. The CommonJS ban stays on everywhere else.

Why .cjs

nx loads non-.ts renderer paths with require(), which can't import an ESM module — and this workspace is "type": "module", so a .js/.mjs renderer would be ESM. .cjs is the format nx's loader can consume here. (A .ts renderer would avoid the eslint scoping but would be the only TypeScript file under scripts/, which is otherwise all plain .mjs.)

Verification

Previewed against current git history via npm run release:dryrun (the changelog path only) — output renders ### 💀 Thank You. Cosmetic only: applies to future nx release changelog runs; existing CHANGELOG.md entries are untouched.

🤖 Generated with Claude Code

@laazyj
laazyj force-pushed the chore/skull-changelog-authors branch from 71f75e5 to aad47c0 Compare July 9, 2026 15:44
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Coverage

Overall line coverage: 99.29% across 21 package(s).

Package Statements Branches Functions Lines
acm 🟢 95.34% 🟢 90.47% 🟢 100.00% 🟢 97.43%
apigateway 🟢 100.00% 🟢 100.00% 🟢 100.00% 🟢 100.00%
budgets 🟢 99.20% 🟢 95.55% 🟢 100.00% 🟢 100.00%
cloudformation 🟢 97.69% 🟢 95.40% 🟢 100.00% 🟢 99.16%
cloudfront 🟢 99.40% 🟢 95.14% 🟢 100.00% 🟢 100.00%
cloudwatch 🟢 95.56% 🟡 89.55% 🟢 100.00% 🟢 98.23%
core 🟢 100.00% 🟢 97.36% 🟢 100.00% 🟢 100.00%
dynamodb 🟢 98.50% 🟡 88.88% 🟢 100.00% 🟢 100.00%
ec2 🟢 98.88% 🟢 97.82% 🟢 100.00% 🟢 99.59%
eslint-plugin 🟡 89.88% 🟡 83.33% 🟢 100.00% 🟢 97.90%
events 🟢 97.50% 🟢 92.30% 🟢 100.00% 🟢 100.00%
examples 🟢 94.78% 🟡 76.66% 🟢 100.00% 🟢 99.06%
iam 🟢 100.00% 🟢 100.00% 🟢 100.00% 🟢 100.00%
lambda 🟢 97.88% 🟢 96.26% 🟢 100.00% 🟢 98.30%
logs 🟢 100.00% 🟢 100.00% 🟢 100.00% 🟢 100.00%
module-compat 🟢 100.00% 🟢 100.00% 🟢 100.00% 🟢 100.00%
neptune 🟢 96.00% 🟡 84.78% 🟢 100.00% 🟢 98.57%
route53 🟢 98.24% 🟢 96.04% 🟢 100.00% 🟢 99.04%
s3 🟢 98.94% 🟢 98.24% 🟢 100.00% 🟢 100.00%
sns 🟢 98.73% 🟢 96.66% 🟢 100.00% 🟢 100.00%
sqs 🟢 99.24% 🟢 97.18% 🟢 100.00% 🟢 100.00%
Total 🟢 97.71% 🟢 93.85% 🟢 100.00% 🟢 99.29%

nx's DefaultChangelogRenderer hardcodes the "❤️ Thank You" authors
heading. Point release.changelog.workspaceChangelog.renderer at a thin
subclass that overrides renderAuthors() to swap the heart for the skull
mark from jasonduffett.net, inheriting all other rendering so upstream
changelog changes still flow through on nx upgrades.

The renderer is CommonJS (.cjs) because nx loads non-".ts" renderer
paths with require(), which cannot import an ESM module in this
"type": "module" workspace. Scope an eslint block to scripts/*.cjs so
require()/module.exports lint cleanly there without relaxing the
CommonJS ban anywhere else.

Cosmetic only; applies to future `nx release changelog` runs. Existing
CHANGELOG.md entries are unchanged. Preview with `npm run release:dryrun`.
@laazyj
laazyj force-pushed the chore/skull-changelog-authors branch from aad47c0 to 8d44942 Compare July 10, 2026 09:05
@laazyj
laazyj merged commit d3561e8 into main Jul 10, 2026
21 checks passed
@laazyj
laazyj deleted the chore/skull-changelog-authors branch July 10, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant