feat: external tax mode#388
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f34163a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mvantellingen
approved these changes
May 13, 2026
BramKaashoek
pushed a commit
that referenced
this pull request
May 13, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @labdigital/commercetools-mock@3.0.0-beta.4 ### Minor Changes - [#388](#388) [`f053fb9`](f053fb9) Thanks [@BramKaashoek](https://github.com/BramKaashoek)! - Add support for `External` and `ExternalAmount` tax modes on carts. ### New behavior - **`External` tax mode** — `LineItem`, `CustomLineItem`, and shipping methods can now carry an `externalTaxRate`: - `createCart` honors `LineItemDraft.externalTaxRate`, `CustomLineItemDraft.externalTaxRate`, and `CartDraft.externalTaxRateForShippingMethod`. - `addLineItem`, `addCustomLineItem`, and `setShippingMethod`/`setCustomShippingMethod` accept `externalTaxRate`. - New update actions: `setLineItemTaxRate`, `setCustomLineItemTaxRate`, `setShippingMethodTaxRate`. - **`ExternalAmount` tax mode** — explicit gross amounts can be supplied per item and at the cart level: - New update actions: `setLineItemTaxAmount`, `setCustomLineItemTaxAmount`, `setShippingMethodTaxAmount`, `setCartTotalTax`. - In this mode the cart's `taxedPrice` is whatever `setCartTotalTax` last set; it is no longer aggregated from line items. `taxedShippingPrice` continues to mirror `shippingInfo.taxedPrice`. - All tax calculations now respect `cart.taxRoundingMode` (`HalfEven` / `HalfUp` / `HalfDown`) instead of always using `Math.round`. ### Cart total recomputation after update actions `CartUpdateHandler.apply` now recomputes `cart.taxedPrice` and `cart.taxedShippingPrice` after every update batch (except in `ExternalAmount` mode, where the cart total is authoritative via `setCartTotalTax`). This fixes a pre-existing latent bug: previously these fields were only computed once during `create()` and were never refreshed after update actions, so e.g. running `setShippingMethod` after cart creation would leave the cart-level aggregate stale. It didn't show up before because `LineItem.taxedPrice` was never populated in any mode, so the aggregate had no contributors that could drift. With the new tax-mode work, line items and custom line items now actually carry `taxedPrice`, which made the gap observable and required fixing. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.