fix(FR-1780): Align the refresh button of the dashboard items #4805
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nowgnuesLee
requested review from
Copilot,
ironAiken2 and
yomybaby
and removed request for
Copilot
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.37% | 517/11819 |
| 🔴 | Branches | 3.58% | 298/8316 |
| 🔴 | Functions | 2.63% | 95/3616 |
| 🔴 | Lines | 4.35% | 503/11560 |
Test suite run success
145 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 582d7c6
yomybaby
left a comment
yomybaby
left a comment
There was a problem hiding this comment.
The padding size of the right and left of the content area is different.
nowgnuesLee
force-pushed
the
fix/align-refresh-button-of-dashboard-items
branch
from
1e00ff0 to
e75646f
Compare
There was a problem hiding this comment.
Pull request overview
This PR standardizes the horizontal padding of dashboard item components by replacing separate paddingLeft and paddingRight properties with the shorthand paddingInline property. This change ensures consistent alignment of refresh buttons across all dashboard items.
- Converts separate left/right padding to
paddingInlineshorthand for better maintainability - Aligns with the existing pattern already used in other dashboard components (AgentStats, MyResource, MyResourceWithinResourceGroup, TotalResourceWithinResourceGroup)
- Fixes visual inconsistency in SessionCountDashboardItem where left padding was
paddingXLbut right padding was onlypadding
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| react/src/components/SessionCountDashboardItem.tsx | Replaces paddingLeft: token.paddingXL and paddingRight: token.padding with paddingInline: token.paddingXL to standardize padding and fix alignment issue |
| react/src/components/RecentlyCreatedSession.tsx | Replaces separate paddingLeft and paddingRight properties with paddingInline: token.paddingXL for consistency |
| react/src/components/ActiveAgents.tsx | Replaces separate paddingLeft and paddingRight properties with paddingInline: token.paddingXL for consistency |
Merge activity
|
resolves #4806 (FR-1780) This PR align the refresh button of the dashboard items. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
fix/align-refresh-button-of-dashboard-items
branch
from
e75646f to
582d7c6
Compare
graphite-app
bot
deleted the
fix/align-refresh-button-of-dashboard-items
branch
resolves #4806 (FR-1780)
This PR align the refresh button of the dashboard items.
Checklist: (if applicable)