fix(FR-1786): fix session launcher resource form initialization

[ironAiken2]

Resolves #4821 (FR-1786)

Add RESOURCE_ALLOCATION_INITIAL_FORM_VALUES to SessionLauncherPage

This PR adds the RESOURCE_ALLOCATION_INITIAL_FORM_VALUES constant to the merged initial values in the SessionLauncherPage component. This ensures that resource allocation form values are properly initialized when the page loads.

Changes

• Import RESOURCE_ALLOCATION_INITIAL_FORM_VALUES from ResourceAllocationFormItems
• Include this constant in the merged initial values calculation to ensure proper resource allocation defaults

This change helps maintain consistent resource allocation values during page initialization and prevents potential undefined values in the form.

[ironAiken2]

• fix: fix session launcher resource form initialization on page refresh #4822
• fix(FR-1786): fix session launcher resource form initialization #4811 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• flow:merge-queue - adds this PR to the back of the merge queue
• flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report for ./react

St.❔	Category	Percentage	Covered / Total
🔴	Statements	4.38%	517/11816
🔴	Branches	3.59%	298/8312
🔴	Functions	2.63%	95/3615
🔴	Lines	4.35%	503/11557

Test suite run success

145 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 6968722

[Copilot]

Pull request overview

This PR fixes a critical bug in the session launcher resource form where page refreshes caused incorrect initialization of resource allocation values. The root cause was improper handling of undefined values in the InputNumberWithSlider component, which triggered unwanted form updates and preset changes.

Key Changes:

• Fixed InputNumberWithSlider to prevent setValue(0) calls when value is undefined by adding _.isNil(value) check
• Added optional chaining for safer access to shmem field properties in resource allocation form
• Replaced dynamic field key retrieval with explicit field key declaration in SessionLauncherPreview for reliable error detection

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
react/src/components/InputNumberWithSlider.tsx	Added null/undefined check before integer normalization to prevent NaN-related bugs that triggered unwanted onChange events
react/src/components/SessionFormItems/ResourceAllocationFormItems.tsx	Added optional chaining for shmem field access; refactored allocation preset checks to use consistent variable reference; removed trailing whitespace
react/src/components/SessionLauncherPreview.tsx	Replaced dynamic field key retrieval with explicit array of resource field keys to ensure proper error detection even when field values are undefined

---

After thoroughly reviewing this PR, I found that all changes are well-implemented and appropriately address the described issue. The fixes are:

1. InputNumberWithSlider.tsx: The addition of !_.isNil(value) correctly prevents the component from trying to normalize undefined values, which was causing undefined % 1 to return NaN and triggering unwanted setValue(0) calls.

2. ResourceAllocationFormItems.tsx: The optional chaining additions (?.shmem) are appropriate defensive programming practices. The refactoring from form.getFieldValue('allocationPreset') to currentAllocationPreset improves code consistency and readability without changing logic.

3. SessionLauncherPreview.tsx: The change from dynamically retrieving keys via _.some(form.getFieldValue('resource'), (_v, key) => ...) to explicitly declaring the field keys is a solid fix. When field values don't exist, getFieldValue may not return all keys, which would cause error detection to fail.

All changes follow TypeScript best practices, maintain proper null safety, and align with the project's coding standards. No i18n violations were found, and the code quality is good.

[nowgnuesLee]

LGTM

[yomybaby]

LGTM

[graphite-app]

Merge activity

• Dec 12, 12:52 AM UTC: yomybaby added this pull request to the Graphite merge queue.
• Dec 12, 12:54 AM UTC: Merged by the Graphite merge queue.