fix(auth): prevent ended mongoose session use in pre-login code cleanup#6485
Open
stakeswky wants to merge 1 commit intolabring:mainfrom
Open
fix(auth): prevent ended mongoose session use in pre-login code cleanup#6485stakeswky wants to merge 1 commit intolabring:mainfrom
stakeswky wants to merge 1 commit intolabring:mainfrom
Conversation
|
User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Preview sandbox Image: |
Preview mcp_server Image: |
Preview fastgpt Image: |
Contributor
Author
|
CLA fixed ✅ Updated the PR commit metadata to use stakeswky@gmail.com and force-pushed. Please re-run CLA check. |
f7980ac to
d9e7733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authCodedelayed cleanup to avoid reusing a transaction-bound document/session aftermongoSessionRunhas ended_idand run cleanup viaMongoUserAuth.deleteOne({ _id })in the timeout callbackCannot set a document's session to a session that has endedruntime error seen in/api/support/user/account/preLoginflowRoot cause
resultis loaded insidemongoSessionRunwith an active mongoose session.A delayed
setTimeoutlater calledresult.deleteOne({ session })after the transaction finished and session was ended, which triggers mongoose session-ended error.Validation
Fixes #6476