fix: add confirmation dialog before resetting settings#481
Conversation
Add a warning dialog with Cancel/Reset buttons before executing Reset CrossOver to prevent accidental settings loss. Also adds separators around the reset menu item in the tray to visually separate it from Quit. Closes #391
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user experience issue where the 'Reset CrossOver' option could be accidentally clicked, leading to loss of all settings. The changes introduce a confirmation step before the reset action is performed and visually separates the reset option in the tray menu, significantly improving user safety and preventing unintended data loss. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a user experience issue by adding a confirmation dialog before resetting settings and visually separating the reset menu item. The changes are well-implemented. My review includes one suggestion for src/main/menu.js to improve code consistency with the rest of the project. The change in src/main/tray.js is a good addition for usability.
|
|
||
| // Open dialog | ||
| reset.app() | ||
| const { dialog } = require('electron') |
There was a problem hiding this comment.
For consistency with the rest of the project and to avoid re-requiring the module on every click, it's better to move this require statement to the top of the file. Most other files in the project (e.g., crossover.js, dialog.js) declare their dependencies at the top.
1 participant
Problem
The "Reset CrossOver" menu item in the tray context menu is positioned right next to "Quit" with no confirmation dialog. Users accidentally click it and lose all their settings.
Changes
src/main/menu.js: Added a warning dialog (dialog.showMessageBox) with Cancel/Reset buttons before executing the reset. Cancel is the default button.src/main/tray.js: Added separators around the reset menu item to visually distinguish it from Quit.Closes #391