Feature: added start locked preference option

[Bora-Valar-Kara]

• Added startLocked checkbox to System Settings
• Function: On startup, startLocked forces hidden.locked = true (overrides startUnlocked)
• Fixed duplicate 'dialog' declaration in menu.js

QoL feature. On regular use, locking in place every time you boot becomes redundant.

Please let me know if this change is something you would want in your upstream.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'Start Locked' preference, giving users more control over the application's startup behavior. It also rectifies a code duplication issue, contributing to overall code quality.

Highlights

• New Feature: Introduced a 'Start Locked' preference option, allowing users to force the application to start in a locked state, overriding the 'Start Unlocked' setting.
• User Experience: The 'Start Locked' option provides a quality-of-life improvement for users who prefer the application to consistently start in a locked state, eliminating the need to manually lock it after each boot.
• Code Correction: Addressed a duplicate declaration of 'dialog' in menu.js, enhancing code maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a 'start locked' preference, allowing the application to launch in a locked state. This new option correctly takes priority over the existing 'start unlocked' setting. The changes include updating the default preferences, adding the new option to the settings UI, and implementing the startup logic. Additionally, the pull request resolves a variable naming conflict in menu.js. The changes appear correct and align with the pull request's goal.

[lacymorrow]

I'm hesitant to merge this, comma, technically the functionality already exists... What does this offer that start unlocked does not?

If you uncheck "start unlocked" and lock the app and restart it, it will still be locked.

[Bora-Valar-Kara]

Owner

True. I overlooked this it seems... (I checked more than once even...)

I just started learning JS and I was tinkering around.

Very nice app! I'm a regular user!

[lacymorrow]

Well, I appreciate you taking the time to make a pull request!
Everything worked by the way and the PR overall was well created for what it's worth.

There's a new version of crossover I'm testing out if you would like to take a look and beta test (need to add windows/linux builds still): https://github.com/lacymorrow/crossover/releases/tag/v4.0.0-beta.1

[lacymorrow]

Oh, and you caught a bug that I overlooked also. Well done, I appreciate it.

Just added Windows/Linux builds to the beta release: https://github.com/lacymorrow/crossover/releases/tag/v4.0.0-beta.1

[Bora-Valar-Kara]

Oh, and you caught a bug that I overlooked also. Well done, I appreciate it.

Just added Windows/Linux builds to the beta release: https://github.com/lacymorrow/crossover/releases/tag/v4.0.0-beta.1

Oh yes! It's small but I hope that was helpful!