Conversation
Spark 3.5.5 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Spark 4.0.0 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests(truncated) |
Contributor
Author
|
Before waiting for the upstream to solve the corresponding issue, import pydantic and pin the version. Tracking: |
lonless9
changed the title
lonless9
force-pushed
the
iceberg-scan
branch
from
1f1bd02 to
12d4b58
Compare
linhr
approved these changes
Oct 16, 2025
Comment on lines
+18
to
+24
| pub mod view_metadata; | ||
| pub mod view_metadata_builder; | ||
| pub mod view_version; | ||
|
|
||
| pub use view_metadata::*; | ||
| pub use view_metadata_builder::*; | ||
| pub use view_version::*; |
Contributor
There was a problem hiding this comment.
If the view is only used for the REST API, we can remove the spec entirely from the sail-iceberg crate.
(Just a comment for future work. No need to change anything for now.)
| catalog = load_catalog( | ||
| "test_catalog", | ||
| type="sql", | ||
| uri=f"sqlite:///{tmp_path}/pyiceberg_catalog.db", |
Contributor
There was a problem hiding this comment.
Does this path work on Windows?
Contributor
Author
There was a problem hiding this comment.
I tried the Windows environment and only had escape_sql_string_literal related issues, and so far all tests have passed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#172
https://iceberg.apache.org/spec/