fix: error snackbar on 403

[v-kessler]

Summary by CodeRabbit

• Bug Fixes
  • Updated error notification behavior: 403 errors now always display notifications, while 404 errors suppress notifications unless explicitly requested.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a6ef481-1aeb-47f1-9fa1-b6843e384dae

📥 Commits

Reviewing files that changed from the base of the PR and between 5db2c14 and 101b497.

📒 Files selected for processing (1)

• src/plugins/functions.ts

---

Walkthrough

The changes modify error handling in the functions plugin by removing forbidden error checks, updating notification suppression logic to suppress 404 errors while always showing 403 errors, and propagating the notify parameter through three error catch blocks.

Changes

Cohort / File(s)	Summary
Error Handling Updates src/plugins/functions.ts	Removed isForbiddenError import; modified snackbar suppression to suppress 404 errors when notify is not explicitly true, while ensuring 403 errors always display; updated three catch blocks (updateStorageCredential, updateStorageProfile, updateWarehouseDeleteProfile) to forward the notify argument to handleError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A hop through error paths we go,
Four-oh-four now hides below,
Four-oh-three stays in the light,
Notify flows left and right,
Errors handled, clean and tight! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-snackbar-on-403

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}