Fix CI typecheck (add tsconfig + typescript) + document docker-image matrix#2
Merged
Conversation
The Typecheck CI step (`npx tsc --noEmit -p tsconfig.json`) never worked: there
was no tsconfig.json in the repo, and `typescript` wasn't a dependency so
`npx tsc` pulled an unrelated impostor package ("This is not the tsc command you
are looking for"). The step failed on every commit.
- Add tsconfig.json for the specs + playwright.config (noEmit, skipLibCheck).
- Add typescript + @types/node devDeps (+ a `typecheck` npm script); lockfile
updated so `npm ci` stays in sync.
- Fix the one real type error tsc then surfaced: the monocart coverage reporter
array wasn't typed as a ReporterDescription tuple.
All four CI steps (install, typecheck, syntax-check, config-load) pass locally.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the new recipes (test-matrix-docker/test-docker, test-matrix-chrome/test-chrome) to the commands table, a 'Testing the shipped Docker image' section (served-UI, seaweed STS deep flows, LAN-IP split-horizon, no AWS), and correct the dashboard doc: runs now reset to the last run (archived-run dropdown for history) instead of accumulating. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
mainCI has been red on every commit — theTypecheckstep(
npx tsc --noEmit -p tsconfig.json) never worked:tsconfig.jsonin the repo, andtypescriptwasn't a dependency, sonpx tscpulled an unrelated impostorpackage (
tsc@2.0.4→ "This is not the tsc command you are looking for").What
CI fix (
fa26ef6)tsconfig.jsonfor the specs +playwright.config(noEmit,skipLibCheck).typescript+@types/nodedevDeps and atypechecknpm script; lockfileupdated so
npm cistays in sync.array wasn't typed as a
ReporterDescriptiontuple.Docs (
04d4975)test-matrix-docker/test-docker(embedded-UI image testing,seaweed STS deep flows, LAN-IP split-horizon, no AWS) and
test-matrix-chrome/test-chromerecipes; correct the dashboard doc (runs now reset to the last runwith an archived-run dropdown, instead of accumulating).
Verification
All four CI steps pass locally:
npm ci,tsc --noEmit,node --checkon theorchestration scripts, and
playwright test --listfor both the authn (dualwebServer) and cedar (premium) config paths.
🤖 Generated with Claude Code