Skip to content

fix: correct benchmark data generation in Mersenne31 field benchmarks#1027

Open
DeVikingMark wants to merge 1 commit intolambdaclass:mainfrom
DeVikingMark:devikingmark
Open

fix: correct benchmark data generation in Mersenne31 field benchmarks#1027
DeVikingMark wants to merge 1 commit intolambdaclass:mainfrom
DeVikingMark:devikingmark

Conversation

@DeVikingMark
Copy link
Copy Markdown

Fixed incorrect loop condition in rand_fp4e() and rand_field_elements() functions that used result.capacity() instead of num parameter, which could generate wrong number of test elements.

Changes:

  • Replace result.capacity() with num in loop conditions
  • Add proper documentation to benchmark helper functions
  • Remove TODO comment after implementation

This ensures benchmark functions generate the expected number of test data elements.

@DeVikingMark DeVikingMark requested a review from a team as a code owner September 21, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant