fix: fall back to describeNamespace when glue lacks namespaceExists#645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#638 exposed a bug that was previously being hidden because
namespaceExistswas swallowing backend errors. Now thatUNSUPPORTEDpropagates correctly, integration setup fails against Glue 0.3.0 since it never implementednamespaceExists.Until lance-format/lance-namespace-impls#127 lands in a release and is in the class path we fallback to
describeNamespaceand whennamespaceExistsreturns unsupported. Missing namespaces map to false viaNAMESPACE_NOT_FOUND. Glue 0.3.0 also returnsTABLE_NOT_FOUNDwhen describing a missing database, so handle that the same way.This is temporary, and will be removed once fixed upstream