Skip to content

ci: add Java 25 to the JNI build-and-test matrix #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuciferYang wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

ci: add Java 25 to the JNI build-and-test matrix #7391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
java-version: [11, 17, 21]
java-version: [11, 17, 21, 25]
name: Build and Test with Java ${{ matrix.java-version }}
steps:
- name: Checkout repository
Expand All @@ -79,7 +79,13 @@ jobs:
distribution: temurin
java-version: ${{ matrix.java-version }}
cache: "maven"
# Skip the format gate on Java 25: google-java-format 1.22.0 (pinned via
# spotless) reaches into com.sun.tools.javac internals and throws
# NoSuchMethodError on JDK 25's javac. No google-java-format release runs
# on JDK 25 without also dropping JDK 11/17 support, so we exclude 25 from
# the (JDK-independent, already-enforced-on-11/17/21) style check instead.
- name: Running code style check with Java ${{ matrix.java-version }}
if: matrix.java-version != '25'
working-directory: java
run: |
mvn spotless:check
Expand All @@ -91,4 +97,7 @@ jobs:
env:
LANCE_INTEGRATION_TEST: "1"
run: |
mvn install
# spotless is also bound into the build lifecycle, so on Java 25 the
# format gate must be skipped here too (-Dspotless.skip=true), not just
# in the standalone step above.
mvn install ${{ matrix.java-version == '25' && '-Dspotless.skip=true' || '' }}
Loading