refactor(index): extract BasicTrainer trait from ScalarIndexPlugin#7395
Open
westonpace wants to merge 7 commits into
Open
refactor(index): extract BasicTrainer trait from ScalarIndexPlugin#7395westonpace wants to merge 7 commits into
westonpace wants to merge 7 commits into
Conversation
…lugin Move the two-stage training API (new_training_request + train_index) out of ScalarIndexPlugin into a new TrainsOnColumnStream trait. ScalarIndexPlugin gains an as_trainer() accessor (default: None) so callers can opt into training without coupling the core plugin interface to it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ugin Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…xPlugin Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…orted Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Update lance-namespace-impls manifest.rs to use basic_trainer() instead of calling new_training_request/train_index directly on ScalarIndexPlugin - Fix typo: "approches" -> "approaches" in registry.rs doc comment - Run cargo fmt to fix formatting diffs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the two-stage training API (new_training_request + train_index) out of ScalarIndexPlugin into a new BasicTrainer trait. ScalarIndexPlugin gains a basic_trainer() accessor (default: None) so callers can opt into training without coupling the core plugin interface to it.