-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(agent): make responseFormat.strict configurable to support optional tool parameters #9535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Nitinref
wants to merge
9
commits into
langchain-ai:main
from
Nitinref:fix-agent-responseformat-strict
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c6a64e2
fix(responses): make strict tool-calling configurable
Nitinref d1a6884
Merge branch 'main' into fix-agent-responseformat-strict
christian-bromann 33d7dd7
test: add strict tool-calling tests for responses
Nitinref 5d0249d
test: add strict tool-calling tests + format responses.ts
Nitinref 158b545
Merge branch 'main' into fix-agent-responseformat-strict
Nitinref e12c27d
fix(responses): correctly pass strict through provider json_schema stβ¦
Nitinref 3f0bd6f
fix: correct strict resolution priority in AgentNode
Nitinref b853ac8
formatting
christian-bromann 5cc8841
Merge branch 'main' into fix-agent-responseformat-strict
Nitinref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
libs/providers/langchain-openai/src/chat_models/tests/responses.strict.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import { ChatOpenAIResponses } from "../responses.js"; | ||
|
|
||
| describe("strict tool-calling configuration", () => { | ||
| it("falls back to supportsStrictToolCalling when strict is undefined", () => { | ||
| const model = new ChatOpenAIResponses({ | ||
| model: "gpt-4o", | ||
| supportsStrictToolCalling: true, | ||
| }); | ||
|
|
||
| const params = model.invocationParams({ | ||
| tools: [ | ||
| { | ||
| type: "function", | ||
| function: { | ||
| name: "test_func", | ||
| description: "testing", | ||
| parameters: { type: "object", properties: {} }, | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect("strict" in params).toBe(false); | ||
|
|
||
| expect((params.tools as Array<{ strict?: boolean }>)[0].strict).toBe(true); | ||
| }); | ||
|
|
||
| it("respects user-provided strict option", () => { | ||
| const model = new ChatOpenAIResponses({ | ||
| model: "gpt-4o", | ||
| supportsStrictToolCalling: true, | ||
| }); | ||
|
|
||
| const params = model.invocationParams({ | ||
| strict: false, | ||
| tools: [ | ||
| { | ||
| type: "function", | ||
| function: { | ||
| name: "test_func", | ||
| description: "testing", | ||
| parameters: { type: "object", properties: {} }, | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| expect("strict" in params).toBe(false); | ||
|
|
||
| expect((params.tools as Array<{ strict?: boolean }>)[0].strict).toBe(false); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to run the tests? I would be interested to know if this is a breaking change