fix: correct translated anchor fragments in zh/ja datasource-plugin#790
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes broken internal anchor links in the Chinese and Japanese datasource-plugin docs by updating link fragments to match the localized heading slugs in the corresponding tool-plugin pages (as generated by the repo’s internal slugify() logic in tools/check-links.py).
Changes:
- Update zh
datasource-pluginlinks to use#4-准备工具代码and#2-完善第三方服务凭据. - Update ja
datasource-pluginlinks to use#4-ツールコードの準備and#2-サードパーティサービス認証情報の完成.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zh/develop-plugin/dev-guides-and-walkthroughs/datasource-plugin.mdx | Updates two /tool-plugin#... anchor fragments to match the zh tool-plugin heading slugs. |
| ja/develop-plugin/dev-guides-and-walkthroughs/datasource-plugin.mdx | Updates two /tool-plugin#... anchor fragments to match the ja tool-plugin heading slugs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix four broken anchors flagged by the CI internal link check (
tools/check-links.py --internal) in the zh and jadatasource-pluginpages.These pages link to
tool-pluginsection headings. The translation pipeline translated the link labels but left the anchor fragments in English (#4-prepare-tool-code,#2-complete-third-party-service-credentials). Because the zh/jatool-pluginheadings are translated, their generated slugs are localized, so the English fragments resolved to nonexistent anchors. The en page passed because its headings stay in English, which is why this only surfaced in the translated files.