feat: add ark multimodal polling plugins#3195
Draft
WH-2099 wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new plugin for BytePlus ModelArk and updates the Volcengine Ark plugin to support multimodal models, specifically Seedance for video and Seedream for image generation. The implementation includes a polling mechanism for asynchronous tasks and logic for handling multimodal inputs like images, videos, and audio. Feedback identifies an issue in the get_num_tokens method for both plugins, where complex message content is not correctly handled during token estimation, and suggests using the _extract_prompt_text helper to fix this.
9c78f35 to
155b3cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocked
This draft PR should not be merged until dify has completed the matching graphon and dify-plugin-daemon upgrades. The end-to-end stack needs polling invocation support before these plugin changes can be safely released.
Tracked by #3194.
Validation
cd models/volcengine && uv run pytest24 passed, 20 skippedcd models/byteplus && uv run pytest17 passed, 1 skippedLive BytePlus generation was not completed because the supplied key returned an inactive-key 401 from the provider.