fix : Plugin table missing for existing PLUGIN_INSTALLED_PATH#748
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a check in server_local.go to verify if a plugin's database record exists before launching it. The reviewer pointed out that only the db.ErrDatabaseNotFound error is handled, meaning other database errors (such as connection timeouts or query failures) are silently ignored, which could allow the plugin to launch in an inconsistent state. The reviewer suggested handling all non-nil errors and logging them appropriately.
fatelei
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #747
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)