Skip to content

fix : Plugin table missing for existing PLUGIN_INSTALLED_PATH#748

Merged
fatelei merged 2 commits into
langgenius:mainfrom
shootercheng:fix/check_plugin_data
Jun 1, 2026
Merged

fix : Plugin table missing for existing PLUGIN_INSTALLED_PATH#748
fatelei merged 2 commits into
langgenius:mainfrom
shootercheng:fix/check_plugin_data

Conversation

@shootercheng
Copy link
Copy Markdown
Contributor

Description

Fixes #747

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working go Pull requests that update go code plugin-daemon labels May 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a check in server_local.go to verify if a plugin's database record exists before launching it. The reviewer pointed out that only the db.ErrDatabaseNotFound error is handled, meaning other database errors (such as connection timeouts or query failures) are silently ignored, which could allow the plugin to launch in an inconsistent state. The reviewer suggested handling all non-nil errors and logging them appropriately.

Comment thread internal/core/control_panel/server_local.go
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2026
@fatelei fatelei merged commit 918ce6f into langgenius:main Jun 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the database data is deleted, the service is restarted, and the plugin process is still running

2 participants