Skip to content

fix: support lowercase proxy environment variables #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcj46548-ux wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: support lowercase proxy environment variables #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e31661d
fix: support lowercase proxy environment variables
jcj46548-ux Jun 6, 2026
52a51d0
test: isolate proxy environment fallback
jcj46548-ux Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions internal/core/local_runtime/setup_python_environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,7 @@ func (p *LocalPluginRuntime) installDependencies(
parent.SetAttributes(attribute.String("uv.path", uvPath), attribute.StringSlice("uv.args", args))
cmd.Env = append(cmd.Env, "VIRTUAL_ENV="+virtualEnvPath, "PATH="+os.Getenv("PATH"))
cmd.Env = append(cmd.Env, "UV_CACHE_DIR="+uvCacheDir)
if p.appConfig.HttpProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("HTTP_PROXY=%s", p.appConfig.HttpProxy))
}
if p.appConfig.HttpsProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("HTTPS_PROXY=%s", p.appConfig.HttpsProxy))
}
if p.appConfig.NoProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("NO_PROXY=%s", p.appConfig.NoProxy))
}
cmd.Env = append(cmd.Env, p.appConfig.ProxyEnv()...)
cmd.Dir = p.State.WorkingPath

// get stdout and stderr
Expand Down
10 changes: 1 addition & 9 deletions internal/core/local_runtime/subprocess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,7 @@ func (r *LocalPluginRuntime) getInstanceCmd() (*exec.Cmd, error) {
}

cmd.Env = cmd.Environ()
if r.appConfig.HttpsProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("HTTPS_PROXY=%s", r.appConfig.HttpsProxy))
}
if r.appConfig.HttpProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("HTTP_PROXY=%s", r.appConfig.HttpProxy))
}
if r.appConfig.NoProxy != "" {
cmd.Env = append(cmd.Env, fmt.Sprintf("NO_PROXY=%s", r.appConfig.NoProxy))
}
cmd.Env = append(cmd.Env, r.appConfig.ProxyEnv()...)
cmd.Env = append(cmd.Env, "INSTALL_METHOD=local", "PATH="+os.Getenv("PATH"))
cmd.Dir = r.State.WorkingPath
return cmd, nil
Expand Down
56 changes: 56 additions & 0 deletions internal/types/app/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"crypto/tls"
"os"
"path/filepath"
"runtime"
"testing"

"github.com/kelseyhightower/envconfig"
Expand Down Expand Up @@ -86,6 +87,61 @@ func TestConfigRedisKeyPrefixField(t *testing.T) {
assert.Equal(t, "enterprise-a", cfg.RedisKeyPrefix)
}

func TestConfigProxyLowercaseFallbacks(t *testing.T) {
t.Setenv("HTTP_PROXY", "")
t.Setenv("HTTPS_PROXY", "")
t.Setenv("NO_PROXY", "")
t.Setenv("http_proxy", "http://lowercase-http:8080")
t.Setenv("https_proxy", "http://lowercase-https:8443")
t.Setenv("no_proxy", "localhost,127.0.0.1")
Comment on lines +94 to +96

@gemini-code-assist gemini-code-assist Bot Jun 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test TestConfigProxyLowercaseFallbacks can be flaky or fail if the host environment running the tests already has HTTP_PROXY, HTTPS_PROXY, or NO_PROXY set. Since envconfig.Process will populate cfg with those uppercase values first, the fallback logic won't be triggered, causing the assertions to fail. To make this test hermetic and independent of the host environment, explicitly clear the uppercase environment variables using t.Setenv before setting the lowercase ones.

Suggested change
t.Setenv("http_proxy", "http://lowercase-http:8080")
t.Setenv("https_proxy", "http://lowercase-https:8443")
t.Setenv("no_proxy", "localhost,127.0.0.1")
t.Setenv("HTTP_PROXY", "")
t.Setenv("HTTPS_PROXY", "")
t.Setenv("NO_PROXY", "")
t.Setenv("http_proxy", "http://lowercase-http:8080")
t.Setenv("https_proxy", "http://lowercase-https:8443")
t.Setenv("no_proxy", "localhost,127.0.0.1")


cfg := Config{}
require.NoError(t, envconfig.Process("", &cfg))
cfg.SetDefault()

assert.Equal(t, "http://lowercase-http:8080", cfg.HttpProxy)
assert.Equal(t, "http://lowercase-https:8443", cfg.HttpsProxy)
assert.Equal(t, "localhost,127.0.0.1", cfg.NoProxy)
}

func TestConfigProxyUppercaseTakesPrecedence(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Windows environment variables are case-insensitive")
}

t.Setenv("HTTP_PROXY", "http://uppercase-http:8080")
t.Setenv("http_proxy", "http://lowercase-http:8080")
t.Setenv("HTTPS_PROXY", "http://uppercase-https:8443")
t.Setenv("https_proxy", "http://lowercase-https:8443")
t.Setenv("NO_PROXY", "internal")
t.Setenv("no_proxy", "localhost")

cfg := Config{}
require.NoError(t, envconfig.Process("", &cfg))
cfg.SetDefault()

assert.Equal(t, "http://uppercase-http:8080", cfg.HttpProxy)
assert.Equal(t, "http://uppercase-https:8443", cfg.HttpsProxy)
assert.Equal(t, "internal", cfg.NoProxy)
}

func TestConfigProxyEnvIncludesUppercaseAndLowercase(t *testing.T) {
cfg := Config{
HttpProxy: "http://proxy-http:8080",
HttpsProxy: "http://proxy-https:8443",
NoProxy: "localhost",
}

assert.ElementsMatch(t, []string{
"HTTP_PROXY=http://proxy-http:8080",
"http_proxy=http://proxy-http:8080",
"HTTPS_PROXY=http://proxy-https:8443",
"https_proxy=http://proxy-https:8443",
"NO_PROXY=localhost",
"no_proxy=localhost",
}, cfg.ProxyEnv())
}

func TestRedisTLSConfig(t *testing.T) {
tests := []struct {
name string
Expand Down
1 change: 1 addition & 0 deletions internal/types/app/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
)

func (config *Config) SetDefault() {
config.SetProxyEnvFallbacks()
switch config.DBType {
case DB_TYPE_OCEANBASE, DB_TYPE_SEEKDB:
config.DBType = DB_TYPE_MYSQL
Expand Down
49 changes: 49 additions & 0 deletions internal/types/app/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package app

import (
"fmt"
"os"
)

func (config *Config) SetProxyEnvFallbacks() {
if config == nil {
return
}

if config.HttpProxy == "" {
Comment on lines +8 to +13

@gemini-code-assist gemini-code-assist Bot Jun 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential nil pointer dereference panics, it is safer to add a nil check for the config receiver before accessing its fields.

Suggested change
func (config *Config) SetProxyEnvFallbacks() {
if config.HttpProxy == "" {
func (config *Config) SetProxyEnvFallbacks() {
if config == nil {
return
}
if config.HttpProxy == "" {

config.HttpProxy = os.Getenv("http_proxy")
}
if config.HttpsProxy == "" {
config.HttpsProxy = os.Getenv("https_proxy")
}
if config.NoProxy == "" {
config.NoProxy = os.Getenv("no_proxy")
}
}

func (config *Config) ProxyEnv() []string {
if config == nil {
return nil
}

env := []string{}
Comment on lines +24 to +29

@gemini-code-assist gemini-code-assist Bot Jun 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential nil pointer dereference panics, add a nil check for the config receiver before accessing its fields.

func (config *Config) ProxyEnv() []string {
	if config == nil {
		return nil
	}
	env := []string{}

if config.HttpProxy != "" {
env = append(env,
fmt.Sprintf("HTTP_PROXY=%s", config.HttpProxy),
fmt.Sprintf("http_proxy=%s", config.HttpProxy),
)
}
if config.HttpsProxy != "" {
env = append(env,
fmt.Sprintf("HTTPS_PROXY=%s", config.HttpsProxy),
fmt.Sprintf("https_proxy=%s", config.HttpsProxy),
)
}
if config.NoProxy != "" {
env = append(env,
fmt.Sprintf("NO_PROXY=%s", config.NoProxy),
fmt.Sprintf("no_proxy=%s", config.NoProxy),
)
}
return env
}