fix: reject empty polling plugin state#342
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enforces a minimum length for the plugin_state field in polling requests and updates the validation logic in LLMPollingResult to reject empty states. Corresponding tests were added to verify these constraints. The reviewer correctly pointed out that since these are Pydantic models, the tests should catch pydantic.ValidationError instead of ValueError to align with Pydantic v2 behavior.
fatelei
previously approved these changes
May 23, 2026
fatelei
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelCheckPollingRequest.plugin_stateto contain at least one item.plugin_stateas invalid for running LLM polling results.Root cause
The existing validation only rejected a missing state payload. Empty mappings could pass even though polling cannot resume with no stored state.
Validation
uv run pytest tests/test_model_polling.pyjust checkCloses #341