Skip to content

feat(agent): name the dropped tool when _init_prompt_tools swallows a conversion exception #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camerono wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(agent): name the dropped tool when _init_prompt_tools swallows a conversion exception #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/dify_plugin/interfaces/agent/strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,20 @@ def _init_prompt_tools(
try:
prompt_tool = self._convert_tool_to_prompt_message_tool(tool)
except Exception:
# api tool may be deleted
logger.exception("Failed to convert tool to prompt message tool")
# api tool may be deleted (e.g. its provider was recreated and
# the app's stored provider_id no longer matches any row in
# tool_api_providers). Naming the tool lets operators grep for
# the drop in plugin_daemon logs instead of guessing why the
# model can't see it.
tool_name = getattr(
getattr(tool, "identity", None), "name", "<unknown>"
)
logger.warning(
"Dropping tool %r from prompt: conversion failed "
"(provider may be deleted or its schema is stale)",
tool_name,
exc_info=True,
)
continue

# save prompt tool
Expand Down