feat: add Milvus TLS env examples#36980
Merged
Merged
Conversation
laipz8200
force-pushed
the
codex/add-milvus-tls-env-examples
branch
from
5de1cfc to
be6a3d6
Compare
laipz8200
changed the title
dosubot
Bot
added
the
size:XS
laipz8200
force-pushed
the
codex/add-milvus-tls-env-examples
branch
from
be6a3d6 to
6b4778a
Compare
fatelei
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #36265. That PR added optional Milvus TLS configuration fields but did not add the corresponding env example entries.
This PR now also clarifies the Docker env-file rule in
docker/README.md: the root.env.examplemust stay limited to variables required to start the default Docker Compose deployment. Optional, advanced, provider-specific, and service-specific variables belong in the appropriateenvs/*.env.examplefile.Changes
MILVUS_SECURE,MILVUS_SERVER_PEM_PATH, andMILVUS_SERVER_NAMEtodocker/envs/vectorstores/milvus.env.exampledocker/README.mdthat non-required env vars must not be added to the root.env.exampleValidation
git diff --check origin/maindocker/README.mdanddocker/envs/vectorstores/milvus.env.example