fix: prevent HTML form elements from rendering in user chat input#37541
Open
ifer47 wants to merge 1 commit into
Open
fix: prevent HTML form elements from rendering in user chat input#37541ifer47 wants to merge 1 commit into
ifer47 wants to merge 1 commit into
Conversation
…nggenius#37414) User input in the Question component was rendered through the full Markdown pipeline, which allows raw HTML tags including <button>, <form>, <input>, etc. These are intentionally permitted in LLM responses for human-input form rendering, but user-supplied messages should never produce interactive HTML elements. Pass customDisallowedElements to the Markdown component in the Question component to strip button, form, input, textarea, label, select, and option elements from user messages. Co-Authored-By: zhipu/glm-5 <zai-org@claude-code-best.win>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<button>,<form>,<input>, etc.<button class="primary-button">Confirm</button>in the chat input would render as an actual clickable buttoncustomDisallowedElementsto the Markdown component in the Question component to stripbutton,form,input,textarea,label,select, andoptionelements from user messagesCloses #37414
Test plan
<button>Confirm</button>in user input is stripped instead of rendered as an interactive element🤖 Generated with Claude Code Best