fix: fall back to existing tracing provider when toggle sends enabled without provider#37546
Open
ifer47 wants to merge 1 commit into
Open
fix: fall back to existing tracing provider when toggle sends enabled without provider#37546ifer47 wants to merge 1 commit into
ifer47 wants to merge 1 commit into
Conversation
… without provider
The tracing enable toggle in the UI sends {"enabled": true} without
including tracing_provider. The AppTracePayload validator rejects this
with "tracing_provider is required when enabled is True", even when a
provider like Langfuse is already configured.
Now the endpoint looks up the current tracing_provider from the app's
existing config before validation, so the toggle works after initial
provider setup.
Closes langgenius#37174
Co-Authored-By: zhipu/glm-5 <zai-org@claude-code-best.win>
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"enabled": true}without includingtracing_providerAppTracePayloadvalidator rejects this with"tracing_provider is required when enabled is True", even when a provider like Langfuse is already configuredtracing_providerfrom the app's existing config before validation, so the toggle works after initial provider setupTest plan
Closes #37174
🤖 Generated with Claude Code Best