Skip to content

fix: close SQLAlchemy sessions in datasource_provider_service #37549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifer47 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: close SQLAlchemy sessions in datasource_provider_service #37549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/services/datasource_provider_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def is_system_oauth_params_exist(self, datasource_provider_id: DatasourceProvide
"""
check if system oauth params exist
"""
with Session(db.engine).no_autoflush as session:
with Session(db.engine) as session:
return (
session.scalar(
select(DatasourceOauthParamConfig)
Expand Down Expand Up @@ -510,7 +510,7 @@ def get_oauth_client(self, tenant_id: str, datasource_provider_id: DatasourcePro
"""
provider = datasource_provider_id.provider_name
plugin_id = datasource_provider_id.plugin_id
with Session(db.engine).no_autoflush as session:
with Session(db.engine) as session:
# get tenant oauth client params
tenant_oauth_client_params = session.scalar(
select(DatasourceOauthTenantParamConfig)
Expand Down
Loading