Skip to content

Fix retry_document_indexing_task exiting early on single document failure #37552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifer47 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix retry_document_indexing_task exiting early on single document failure #37552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b4e6a0
Fix retry task exiting early and skipping remaining documents
ifer47 Jun 16, 2026
00652bc
[autofix.ci] apply automated fixes
ifer47 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions api/tasks/retry_document_indexing_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,20 @@ def retry_document_indexing_task(dataset_id: str, document_ids: list[str], user_
"your subscription."
)
except Exception as e:
document = session.scalar(
select(Document).where(Document.id == document_id, Document.dataset_id == dataset_id).limit(1)
)
if document:
document.indexing_status = IndexingStatus.ERROR
document.error = str(e)
document.stopped_at = naive_utc_now()
session.add(document)
session.commit()
redis_client.delete(retry_indexing_cache_key)
remaining_ids = document_ids[document_ids.index(document_id) :]
for remaining_id in remaining_ids:
remaining_doc = session.scalar(
select(Document)
.where(Document.id == remaining_id, Document.dataset_id == dataset_id)
.limit(1)
)
if remaining_doc:
remaining_doc.indexing_status = IndexingStatus.ERROR
remaining_doc.error = str(e)
remaining_doc.stopped_at = naive_utc_now()
session.add(remaining_doc)
redis_client.delete(f"document_{remaining_id}_is_retried")
session.commit()
return

logger.info(click.style(f"Start retry document: {document_id}", fg="green"))
Expand All @@ -77,7 +81,7 @@ def retry_document_indexing_task(dataset_id: str, document_ids: list[str], user_
)
if not document:
logger.info(click.style(f"Document not found: {document_id}", fg="yellow"))
return
continue
try:
# clean old data
index_processor = IndexProcessorFactory(document.doc_form).init_index_processor()
Expand Down