Fix distributed CSV comparison test#12
Conversation
|
We have huge changes of the code coming soon with a new Spack and a new structure for the different applications. I will wait for these changes to be pushed before merging this MR. I hope to push before the end of the month. Thank you! |
|
Sorry for the delay! The new version of the code is finally out. |
Thankyou for your message . I will review the new code and make changes accordingly. |
c408cc9 to
f5f4d98
Compare
|
Hello, I saw the new code changes. However, distributed regression test in the new codebase was still reading those .csv files as tab-separated text. |
|
Thank you for the fix, I tested it on our CI internally and this causes the test to fail (as it should!) I will merge this here and proceed to push a fix to the github asap for the failing test. |
|
Appreciate it. Will love to learn more and contribute more. |
Summary
Testing
bash -n tools/test_distributed.shgit diff --checkcmake -S . -B build -G Ninja -DENABLE_UNIT_TESTS=ON -DENABLE_VERIFICATION=ON. Configure stopped because FleCSI is not installed in my local WSL environment.