Skip to content

Generalized freeze subroutine#108

Open
cnegre wants to merge 4 commits into
masterfrom
freezecoord
Open

Generalized freeze subroutine#108
cnegre wants to merge 4 commits into
masterfrom
freezecoord

Conversation

@cnegre
Copy link
Copy Markdown
Collaborator

@cnegre cnegre commented May 28, 2019

Generalized freeze subroutine.

@cnegre cnegre requested review from cawkwell and enriquemasa May 28, 2019 16:41
@nfaguirrec
Copy link
Copy Markdown
Contributor

Maybe I am wrong, but I think that the vector FREEZEID is never deallocated. I suggest taking a look at that.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2019

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.1%. Comparing base (aee85aa) to head (147efdd).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/constraints_mod.F90 62.5% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #108     +/-   ##
========================================
- Coverage    46.1%   46.1%   -0.1%     
========================================
  Files         200     200             
  Lines       16321   16333     +12     
========================================
+ Hits         7528    7532      +4     
- Misses       8793    8801      +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cnegre
Copy link
Copy Markdown
Collaborator Author

cnegre commented May 28, 2019 via email

Comment thread src/constraints_mod.F90
DO I = 1,NFREEZE
READ(444,*)FREEZEID(I)
READ(444,*)FREEZEID(I), FREEZEIDX(I), FREEZEIDY(I), FREEZEIDZ(I)
FREEZEIDX(I) = 1 - FREEZEIDX(I)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a check that FREEZEID[XYZ] is really in [0, 1]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants