Conversation
Collaborator
|
I saw that you made some updates, is this ready for review and did some of those changes reduce those downsides? |
Collaborator
Author
|
Partially, ursa-dashboard now has uses the HITL callbacks and There's a default callback handler in, but it hasn't been fully patched into the examples |
Collaborator
|
A couple things: I think this is ready to merge, but I wanted to bring up a couple things I noticed:
ursa> execute make a png with a plot of the first 2100 prime number spacings
✏️ Writing file: prime_spacings.py
Writing file: prime_spacings.py ✔ File written: /path/to/workspace/prime_spacings.py
✅ File written: prime_spacings.py
INFO: 127.0.0.1:51037 - "GET /runs/01KPXPY5M6X9RD82C871T5JWFG/events?after_seq=0&limit=5000 HTTP/1.1" 404 Not Found
INFO: 127.0.0.1:50967 - "GET /sessions/01KPXPST4Q9NTC22Q8375KCAQN/workspace HTTP/1.1" 200 OK
INFO: 127.0.0.1:51144 - "GET /runs/01KRN71S2P3XG2WY0NMBCCY6TC/events?after_seq=0&limit=5000 HTTP/1.1" 200 OK
INFO: 127.0.0.1:51037 - "GET /sessions/01KPXPST4Q9NTC22Q8375KCAQN HTTP/1.1" 200 OK
INFO: 127.0.0.1:51144 - "GET /runs/01KPXPY5M6X9RD82C871T5JWFG/events?after_seq=0&limit=5000 HTTP/1.1" 404 Not Found
INFO: 127.0.0.1:51037 - "GET /sessions/01KPXPST4Q9NTC22Q8375KCAQN/workspace HTTP/1.1" 200 OK
INFO: 127.0.0.1:51144 - "GET /runs/01KRN71S2P3XG2WY0NMBCCY6TC/events?after_seq=0&limit=5000 HTTP/1.1" 200 OKI dont think this needs to hold things up much but thought I'd touch base with you first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excises print statements from agents and tools and replaces them with LangGraph events.
This gives the following wins:
The downsides:
Events aren't printed by default (so nothing is surfaced, this mainly effects the python interface)
Callback code can get rather entangled with the rest of the Agent code (see src/cli/callbacks.py)
feat: add reusable agent event tagging
feat: emit progress events from agents
feat: emit progress events from tools
feat: render hitl tool progress callbacks