Skip to content

Import localization composable from support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swarakaka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Import localization composable from support #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions resources/js/components/fields/CheckboxList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<script setup lang="ts">
import { computed, ref, reactive, watch } from 'vue'
import { Input } from '@/components/ui/input'
import { Collapsible, CollapsibleContent, CollapsibleTrigger } from '@/components/ui/collapsible'
import * as LucideIcons from 'lucide-vue-next'
import { useLocalization } from '@/composables/useLocalization'
import { useLocalization } from '@laravilt/support/composables'

// Initialize localization
const { trans } = useLocalization()
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/fields/KeyValue.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Button } from '@/components/ui/button'
import * as LucideIcons from 'lucide-vue-next'
import { Plus, X, GripVertical } from 'lucide-vue-next'
import { ref, computed } from 'vue'
import { useLocalization } from '@/composables/useLocalization'
import { useLocalization } from '@laravilt/support/composables'
Copy link

@coderabbitai coderabbitai bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Check dependency declaration in package manifests =="
fd -HI '^package\.json$' | while read -r f; do
  echo "--- $f ---"
  rg -n '"@laravilt/support"\s*:' "$f" || true
done

echo
echo "== Check lockfiles for resolved package =="
fd -HI '^(pnpm-lock\.yaml|package-lock\.json|yarn\.lock)$' | while read -r f; do
  echo "--- $f ---"
  rg -n '@laravilt/support' "$f" | head -n 30 || true
done

echo
echo "== Check new import usage across field components =="
rg -n --type vue "from '@laravilt/support/composables'"

echo
echo "== Ensure legacy import path is removed =="
rg -n --type vue "@/composables/useLocalization" || true

Repository: laravilt/forms

Length of output: 277

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Repo structure =="
ls -la
echo

echo "== package.json content =="
if [ -f package.json ]; then
  cat package.json
fi
echo

echo "== Check lockfiles =="
fd -HI '^(pnpm-lock|package-lock|yarn\.lock)' | head -20 || true
echo

echo "== Find all .vue files =="
fd '\.vue$' | head -20
echo

echo "== Search for '@laravilt/support/composables' import in .vue files =="
rg '@laravilt/support/composables' --no-type-list 2>/dev/null || rg '@laravilt/support/composables' || true
echo

echo "== Search for legacy `@/composables/useLocalization` import =="
rg '@/composables/useLocalization' --no-type-list 2>/dev/null || rg '@/composables/useLocalization' || true
echo

echo "== Check the specific file mentioned in review =="
if [ -f "resources/js/components/fields/KeyValue.vue" ]; then
  echo "--- KeyValue.vue exists ---"
  head -20 "resources/js/components/fields/KeyValue.vue"
fi

Repository: laravilt/forms

Length of output: 9707

Add @laravilt/support as a dependency in package.json before merge.

The new import on line 7 references an external package that is not declared in package.json dependencies. All 6 .vue files (KeyValue.vue, Repeater.vue, Select.vue, CheckboxList.vue, and SheetContent.vue) have been consistently migrated to use @laravilt/support/composables, but without this package in the dependency list, the build will fail with an unresolved module error.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@resources/js/components/fields/KeyValue.vue` at line 7, The project imports
useLocalization from `@laravilt/support` (see KeyValue.vue and the other migrated
components Repeater.vue, Select.vue, CheckboxList.vue, SheetContent.vue) but
that package is not declared in package.json; add "@laravilt/support" to the
dependencies in package.json (choose the appropriate semver version used
elsewhere or the latest compatible release), then run your package manager
install (npm/yarn/pnpm) so the import resolves and the build succeeds.


// Initialize localization
const { trans } = useLocalization()
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/fields/Repeater.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import IconPicker from './IconPicker.vue'
import MarkdownEditor from './MarkdownEditor.vue'
import PinInput from './PinInput.vue'
import RateInput from './RateInput.vue'
import { useLocalization } from '@/composables/useLocalization'
import { useLocalization } from '@laravilt/support/composables'

// Initialize localization
const { trans } = useLocalization()
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/fields/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import TextInput from './TextInput.vue'
import Textarea from './Textarea.vue'
import Toggle from './Toggle.vue'
import { useReactiveField } from '../../composables/useReactiveField'
import { useLocalization } from '@/composables/useLocalization'
import { useLocalization } from '@laravilt/support/composables'

// Initialize localization
const { trans } = useLocalization()
Expand Down