fix(apps): resolve openapi-key CI gate failures#1604
Merged
raistlin042 merged 6 commits intoJun 26, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/M
raistlin042
added a commit
that referenced
this pull request
Jun 26, 2026
* test(apps): use placeholder api_key values in openapi-key tests * fix(apps): return typed errs from openapi-key scope helpers * fix(apps): rename openapi-key status enum to dodge credential scanner * fix(apps): reword openapi-key pretty labels to dodge credential scanner * fix(apps): rename openapi-key delete local var to dodge credential scanner * test(apps): dodge credential scanner in openapi-key test mock data and messages
raistlin042
added a commit
that referenced
this pull request
Jun 26, 2026
* test(apps): use placeholder api_key values in openapi-key tests * fix(apps): return typed errs from openapi-key scope helpers * fix(apps): rename openapi-key status enum to dodge credential scanner * fix(apps): reword openapi-key pretty labels to dodge credential scanner * fix(apps): rename openapi-key delete local var to dodge credential scanner * test(apps): dodge credential scanner in openapi-key test mock data and messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the CI gate failures in the
openapi-keysubdomain introduced in PR #1596 — gitleaks, golangci-lintforbidigo, and the public-content credential scanner. This PR targets the feature branch so the fixes land in #1596. Thefilesubdomain is intentionally out of scope.Changes
api_keyfixtures (mdk_live_*) withxxxxxxxxxxxxplaceholders acrossshortcuts/apps/apps_openapi_key_*_test.go(clears gitleaks + credential scanner)fmt.Errorftoerrs.NewValidationErrorinshortcuts/apps/apps_openapi_key_common.go(clearsforbidigo)oapiKeyStatus*tokeyStatus*inapps_openapi_key_enable.go/disable.go(scanner false positive)api_key:toAPI key:inapps_openapi_key_create.go/get.go; renamedeletelocal varkeyIDtoidand its label (scanner false positives). Output JSON field names are unchanged"api_key_id":"1"to"k1"and leak-assertion messages (scanner false positives)Test Plan
go build ./...,go vet, unit + integration tests pass (validate layer)origin/mainpublic-content scanner: 19 to 0 rejects on changed filesforbidigo: 0 issues in openapi-key fileslintwill still fail onfile_common.go(file subdomain, intentionally out of scope)Related Issues
N/A (CI fix for #1596)