Skip to content

fix(auth): remove ' useless settings'#1654

Merged
liangshuo-1 merged 1 commit into
mainfrom
fix/lark-shared-claude
Jun 29, 2026
Merged

fix(auth): remove ' useless settings'#1654
liangshuo-1 merged 1 commit into
mainfrom
fix/lark-shared-claude

Conversation

@yballul-bytedance

@yballul-bytedance yballul-bytedance commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refine the lark-shared auth guidance by removing the outdated reference to “Useless settings / update-config”. This keeps the auth flow instructions focused on the
supported CLI path and avoids redirecting users to an unrelated setup flow.

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark-cli <domain> <command> flow works as expected
  • Docs-only change; no runtime behavior changed

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Simplified the authentication guidance by removing the explicit restriction about routing these questions to “Claude settings / update-config,” while still directing authentication-related questions through this skill and retaining coverage for scope, business domain, login/logout state, and authorization revocation issues.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

skills/lark-shared/SKILL.md removes the explicit ban on routing authentication-related questions to "Claude settings / update-config" while keeping the rest of the auth guidance unchanged.

Changes

Auth Skill Routing Directive

Layer / File(s) Summary
Remove Claude settings routing exclusion from auth directive
skills/lark-shared/SKILL.md
The auth quick-reference line drops the explicit prohibition on routing to "Claude settings / update-config".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • larksuite/cli#1169: Also touches shared skill routing guidance for authentication-related handling across skills.
  • larksuite/cli#1598: Directly modifies the same "认证任务速查" subsection in skills/lark-shared/SKILL.md.

Suggested labels

domain/ccm

Suggested reviewers

  • albertnusouo

Poem

🐇 One little line, pared right down,
The auth path keeps its friendly crown.
No extra ban to slow the flow,
Just hop to skill and let it go.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to auth docs, but the phrase "useless settings" is too vague to clearly describe the actual change. Rename it to clearly state the docs change, such as removing the Claude settings/update-config reference from auth guidance.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description matches the template overall, with clear Summary, Test Plan, and Related Issues sections; only the Changes section is missing.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lark-shared-claude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.71%. Comparing base (ebb0b6f) to head (72b09a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files         810      810           
  Lines       81839    81839           
=======================================
  Hits        61142    61142           
  Misses      16131    16131           
  Partials     4566     4566           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@72b09a9c95a8101a8eeff52178a4deb95ed0d66e

🧩 Skill update

npx skills add larksuite/cli#fix/lark-shared-claude -y -g

@liangshuo-1 liangshuo-1 changed the title fix(auth): remove 'claude settings' fix(auth): remove ' useless settings' Jun 29, 2026
@liangshuo-1 liangshuo-1 merged commit 4a5a669 into main Jun 29, 2026
59 of 63 checks passed
@liangshuo-1 liangshuo-1 deleted the fix/lark-shared-claude branch June 29, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants