Skip to content

recursive presigned url 404 handling - #605

Merged
msnidal merged 1 commit into
mainfrom
mark/incomplete-directory-download-cache
Jul 10, 2026
Merged

recursive presigned url 404 handling#605
msnidal merged 1 commit into
mainfrom
mark/incomplete-directory-download-cache

Conversation

@msnidal

@msnidal msnidal commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

CodeAnt-AI Description

Keep directory downloads from leaving stale version markers when they are incomplete

What Changed

  • Directory downloads now only keep the local version marker when the download finishes successfully
  • If a partial download leaves files behind, any existing version marker is removed so the folder is not treated as fully up to date
  • File downloads follow the same completed-only behavior for setting the version marker

Impact

✅ Fewer false "up to date" downloads
✅ Safer retry after interrupted directory downloads
✅ Clearer cache state for incomplete downloads

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai

codeant-ai Bot commented Jul 10, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Jul 10, 2026
Comment thread src/latch/ldata/path.py
@codeant-ai

codeant-ai Bot commented Jul 10, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

@msnidal
msnidal force-pushed the mark/incomplete-directory-download-cache branch from 4101e54 to 5d55e84 Compare July 10, 2026 23:42
@msnidal
msnidal force-pushed the mark/incomplete-directory-download-cache branch from 5d55e84 to 0faa9dc Compare July 10, 2026 23:50
@msnidal
msnidal merged commit c9f53f2 into main Jul 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant