fix: evaluation detail type should be optional#1061
Closed
Conversation
joker23
commented
Jan 14, 2026
packages/sdk/react-native/src/hooks/variation/LDEvaluationDetail.ts
Outdated
Show resolved
Hide resolved
joker23
commented
Jan 14, 2026
7cce22d to
254ab72
Compare
d9cda1b to
2bfc2e8
Compare
2d147ec to
384093e
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
384093e to
8c8a043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Aligns evaluation detail typings and removes deprecated browser compat code.
reasonoptional inLDEvaluationDetailandLDEvaluationDetailTypedinshared/sdk-clientfor better compatibilityLDEvaluationDetail/LDEvaluationDetailTyped(nullablereason) and re-export; updateuseTypedVariationDetailto use these typessrc/compatmodule, related tests, export entries, and build entry; delete upgrade docs; simplifypackage.jsonexports andtsupconfigWritten by Cursor Bugbot for commit 8c8a043. This will update automatically on new commits. Configure here.