Skip to content

chore: Create FDv2 streaming data source #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jsonbailey wants to merge 1 commit into
base: jb/sdk-1544/fdv2-polling-data-source
Choose a base branch
from
Draft

chore: Create FDv2 streaming data source #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/ldclient-rb/data_system.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
require 'ldclient-rb/interfaces/data_system'
require 'ldclient-rb/config'
require 'ldclient-rb/impl/data_system/polling'
require 'ldclient-rb/impl/data_system/streaming'

module LaunchDarkly
#
Expand Down Expand Up @@ -132,9 +133,8 @@ def self.fdv1_fallback_ds_builder
# @return [Proc] A proc that takes (sdk_key, config) and returns a streaming data source
#
def self.streaming_ds_builder
# TODO(fdv2): Implement streaming data source builder
lambda do |_sdk_key, _config|
raise NotImplementedError, "Streaming data source not yet implemented for FDv2"
lambda do |sdk_key, config|
LaunchDarkly::Impl::DataSystem::StreamingDataSourceBuilder.new(sdk_key, config).build
end
end

Expand Down
Loading