fix: drain process output before returning, kill orphaned speedtest, thread-safe capture#927
Merged
Merged
Conversation
…thread-safe capture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External-process plumbing defects across the shared runner and two consumers.
Changes
WaitForExitAsyncreturns when the process exits, but the asyncBeginOutputReadLine/BeginErrorReadLinepumps may not have raised their final lines, so callers that snapshot output immediately lost the last lines (e.g. NetworkRepair, chkdsk, winget). Added aproc.WaitForExit()(on a thread-pool thread, only when not cancelled) to block until both readers reach end-of-stream. Fixes the truncation at the seam for all consumers.ReadToEndAsyncpropagated before the try/catch that kills the child, orphaningspeedtest.exe. Wrapped the reads + wait in one try; theOperationCanceledExceptioncatch now kills the process tree on any cancellation path.List<string>written by the concurrent stdout+stderr reader threads (data race: dropped/corrupted lines). Switched toConcurrentQueue<string>, materialized (ToArray()/ToList()) before parsing.Tests
WingetService/SystemHealthparse tests still pass (the parsers are unchanged; only the collector type changed). The concurrency/orphan-kill paths require live process I/O and aren't unit-testable; they mirror the audit's recommended fixes.Build: 0 warnings / 0 errors. Version 1.20.38.