fix: clear persisted performance snapshot on Restore All and serialize baseline capture#933
Merged
Merged
Conversation
…e baseline capture
20196fc to
6330a1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Performance Mode reversibility defects.
Changes
RestoreAllAsynccleared the in-memory_snapshotbut never deletedperformance-snapshot.json. SinceEnsureSnapshotAsyncseeds the baseline withLoadSnapshot(), the next Apply reloaded the now-reverted pre-restore state as its baseline, and a later Restore All could re-apply stale values. AddedPerformanceService.DeleteSnapshot()(guarded likeSaveSnapshot) and call it after a successful Restore All.EnsureSnapshotAsync, which does an unguarded_snapshot ??= Load() ?? Take(). Two running together could both see null and race the capture/save. Wrapped the load-modify in aSemaphoreSlim(1,1)so the baseline is captured exactly once. (Disposed inDispose.)Notes
Build: 0 warnings / 0 errors. Version 1.20.41. (Stacks on #930; will rebase before merge.)