Skip to content

ci: audit and update PR preview workflows - #240

Open
ishwar170695 wants to merge 3 commits into
layer5io:masterfrom
ishwar170695:ci/pr-preview-workflow-audit
Open

ci: audit and update PR preview workflows#240
ishwar170695 wants to merge 3 commits into
layer5io:masterfrom
ishwar170695:ci/pr-preview-workflow-audit

Conversation

@ishwar170695

@ishwar170695 ishwar170695 commented Aug 7, 2026

Copy link
Copy Markdown

Notes for Reviewers

This PR audits and updates the PR preview workflows for academy-theme following the workflow review checklist shared by Lenox Wiltshire.

Summary

  • Pin GitHub Actions to immutable commit SHAs while preserving each workflow's existing major version.
  • Expand preview workflow path filters to include all Hugo sources that affect rendered output.
  • Align the minimum Hugo version in hugo.yaml with the hugo-extended version in package.json.
  • Remove obsolete Hugo CLI and Dart Sass setup steps from the preview build workflow.
  • Add wait-for-pages-deployment: false to the preview deployment workflow.
  • Update the preview deployment comment to the standardized format with the GitHub Pages deployment tracking link.

Verification

  • Verified all pinned SHAs against upstream Git tags using git ls-remote --tags.
  • Confirmed Hugo version alignment (0.158.0) between hugo.yaml and package.json.
  • Successfully built the site locally with npm run build:preview (Hugo v0.158.0).
  • Ran git diff --check to ensure there are no whitespace or formatting issues.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Chores
    • Improved documentation preview builds by detecting changes across additional content and configuration files.
    • Updated workflow tooling for more reliable and secure preview builds and deployments.
    • Enhanced deployment status messages with a link for tracking progress.
    • Simplified preview deployment behavior to reduce unnecessary waiting.

Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 946bc063-d4fe-48f6-81f9-d7a2c29fde00

📥 Commits

Reviewing files that changed from the base of the PR and between 437c919 and 84695a3.

📒 Files selected for processing (1)
  • .github/workflows/build-docs-preview.yml

📝 Walkthrough

Walkthrough

The documentation preview workflows now monitor more site and dependency paths, use updated pinned GitHub Actions, remove obsolete installation comments, and post revised preview deployment messages without waiting for Pages deployment.

Changes

Documentation preview workflows

Layer / File(s) Summary
Preview build triggers and actions
.github/workflows/build-docs-preview.yml
The build workflow watches additional site and dependency paths. It removes obsolete Hugo and Dart Sass installation comments, updates pinned actions, and retains failure behavior when no artifact files are found.
Preview deployment actions and messaging
.github/workflows/deploy-docs-preview.yml
The deployment workflow updates pinned action references, disables waiting for Pages deployment, and posts a message with a refresh note and Pages workflow link.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • layer5io/academy-theme#231 — This issue concerns standardizing the documentation preview build and deployment workflows updated here.

Possibly related PRs

Suggested reviewers: banana-three-join

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the audit and updates to the PR preview workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@banana-three-join banana-three-join left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the scope of the audit only to the Build Site Preview and the Site Preview Post-Build workflows. Revert on the changes made to any of the other workflows.


- name: Setup Go
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression in version


- name: Setup Node
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression in version


- name: Upload build artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression in version


- name: Setup Node
uses: actions/setup-node@v7
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression in version

@ishwar170695

Copy link
Copy Markdown
Author

Please keep the scope of the audit only to the Build Site Preview and the Site Preview Post-Build workflows. Revert on the changes made to any of the other workflows.

The scope has been restricted and v7 pins have been restored. Please review when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants