Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR appears to be a “final polish” sweep across the codebase: normalizing comment punctuation (replacing Unicode em-dashes with ASCII hyphens), adding proper top-level documentation/licensing files, and making a couple of small configuration/UI tweaks.
Changes:
- Normalize many comments/strings from
—to-across C++ and GLSL sources. - Add/replace repository documentation and licensing files (README.md, LICENSE, COPYRIGHT) and remove older docs.
- Remove the FastNoiseLite FetchContent dependency from CMake and change SSAO default half-resolution setting.
Reviewed changes
Copilot reviewed 79 out of 87 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/shared/Mobs/PlayerMovement.cpp | Comment dash normalization. |
| src/shared/Entity.cpp | Comment dash normalization. |
| src/shared/Chunk.cpp | Comment dash normalization. |
| src/server/World.cpp | Comment dash normalization. |
| src/server/Server.cpp | Comment dash normalization. |
| src/server/ChunkGeneration.cpp | Comment dash normalization. |
| src/client/WaterRenderer.cpp | Comment dash normalization. |
| src/client/WaterFramebuffer.cpp | Comment dash normalization. |
| src/client/VideoPlayer.cpp | Comment dash normalization (commented-out code). |
| src/client/VegetationRenderer.cpp | Comment dash normalization. |
| src/client/TextureManager.cpp | Comment dash normalization. |
| src/client/TerrainDebugWindow.cpp | Comment dash normalization. |
| src/client/SSAO.cpp | Comment dash normalization. |
| src/client/SkyLUT.cpp | Comment dash normalization. |
| src/client/Renderer.cpp | Comment dash normalization. |
| src/client/menus/MainMenu.cpp | Update displayed version string to “alpha 1.0”. |
| src/client/menus/InventoryUI.cpp | Comment dash normalization. |
| src/client/Lighting.cpp | Comment dash normalization. |
| src/client/items/ItemPropEntityManager.cpp | Comment dash normalization. |
| src/client/items/ItemPropEntity.cpp | Comment dash normalization. |
| src/client/HeldItemRenderer.cpp | Comment dash normalization. |
| src/client/GBuffer.cpp | Comment dash normalization. |
| src/client/ChunkRenderer.cpp | Comment dash normalization. |
| src/client/characters/LivingEntitiesManager.cpp | Comment dash normalization. |
| src/client/characters/cube.cpp | Comment dash normalization. |
| src/client/characters/ClientCreeper.cpp | Comment dash normalization. |
| src/client/characters/Character.cpp | Comment dash normalization. |
| src/client/Camera.cpp | Comment dash normalization. |
| src/client/blockRenderingHelperFunctions.cpp | Comment dash normalization. |
| src/client/AudioManager.cpp | Comment dash normalization (including log message text). |
| src/client/App.cpp | Comment dash normalization. |
| shaders/water.vert | Comment dash normalization. |
| shaders/water.frag | Comment dash normalization. |
| shaders/water_placed.vert | Comment dash normalization. |
| shaders/water_placed.frag | Comment dash normalization. |
| shaders/vegetation.vert | Comment dash normalization. |
| shaders/vegetation.frag | Comment dash normalization. |
| shaders/terrain_vertex_decode.glsl | Comment dash normalization. |
| shaders/terrain_depth_prepass.vert | Comment dash normalization. |
| shaders/terrain_depth_prepass.frag | Comment dash normalization. |
| shaders/skyLUT.frag | Comment dash normalization. |
| shaders/sky.frag | Comment dash normalization. |
| shaders/luminance_reduce.frag | Comment dash normalization. |
| shaders/lighting.vert | Comment dash normalization. |
| shaders/lighting.frag | Comment dash normalization. |
| shaders/gui.vert | Comment dash normalization. |
| shaders/entity_lighting.glsl | Comment dash normalization. |
| shaders/cubePropShader.vert | Comment dash normalization. |
| shaders/cubePropShader.frag | Comment dash normalization. |
| shaders/clouds_composite.frag | Comment dash normalization. |
| shaders/characterCube.vert | Comment dash normalization. |
| shaders/characterCube.frag | Comment dash normalization. |
| README.md | Add a full project README (replaces legacy README). |
| README | Remove legacy short README file. |
| LICENSE | Add AGPLv3 license text. |
| include/shared/Protocol.hpp | Comment dash normalization. |
| include/shared/Network.hpp | Comment dash normalization. |
| include/shared/Entity.hpp | Comment dash normalization. |
| include/shared/CommonWorld.inl | Comment dash normalization. |
| include/shared/Chunk.hpp | Comment dash normalization. |
| include/server/Server.hpp | Comment dash normalization. |
| include/client/WaterRenderer.hpp | Comment dash normalization. |
| include/client/ui/TerrainDebugWindow.hpp | Comment dash normalization. |
| include/client/SSAO.hpp | Change SSAO default half-resolution to false + comment dash normalization. |
| include/client/Renderer.hpp | Comment dash normalization. |
| include/client/PackedVertex.hpp | Comment dash normalization. |
| include/client/Lighting.hpp | Comment dash normalization. |
| include/client/items/ItemPropEntityManager.hpp | Comment dash normalization. |
| include/client/HeldItemRenderer.hpp | Comment dash normalization. |
| include/client/GBuffer.hpp | Comment dash normalization. |
| include/client/ChunkRenderer.hpp | Comment dash normalization. |
| include/client/characters/LivingEntitiesManager.hpp | Comment dash normalization. |
| include/client/characters/IClientEntity.hpp | Comment dash normalization. |
| include/client/characters/ClientCreeper.hpp | Comment dash normalization. |
| include/client/AutoExposure.hpp | Comment dash normalization. |
| include/client/AudioManager.hpp | Comment dash normalization. |
| doc | Remove legacy doc file. |
| COPYRIGHT | Add copyright/licensing notice and asset licensing note. |
| CMakeLists.txt | Remove FastNoiseLite FetchContent and include paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.