Update commit message guidelines in contribute.md#753
Open
marwahaha wants to merge 1 commit intoleanprover-community:lean4from
Open
Update commit message guidelines in contribute.md#753marwahaha wants to merge 1 commit intoleanprover-community:lean4from
marwahaha wants to merge 1 commit intoleanprover-community:lean4from
Conversation
Clarify the format for pull request titles and descriptions, including examples and explanations.
Contributor
|
Thanks for your PR! Let's wait for the discussion in mathlib4#32380 to converge first, so we can adjust the wording here to match. |
Contributor
|
The mathlib PR has been merged: can you adjust the wording in this PR to match what you did there? Then I'm happy to take a look again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got confused by the examples so I tried to make them clearer.
see leanprover-community/mathlib4#32380