perf: simplify cbv ite/dite simprocs by reducing Decidable instance directly#12677
Open
wkrozowski wants to merge 1 commit intoleanprover:masterfrom
Open
perf: simplify cbv ite/dite simprocs by reducing Decidable instance directly#12677wkrozowski wants to merge 1 commit intoleanprover:masterfrom
cbv ite/dite simprocs by reducing Decidable instance directly#12677wkrozowski wants to merge 1 commit intoleanprover:masterfrom
Conversation
…ce directly This PR replaces the `Decidable.decide` + `eq_true_of_decide`/`eq_false_of_decide` approach in `simpIteCbv` and `simpDIteCbv` with direct pattern matching on the `Decidable` instance for `isTrue`/`isFalse`. This produces simpler proof terms and reduces code duplication by extracting shared helpers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
!bench |
|
Benchmark results for 317a97c against f31f508 are in! @wkrozowski
Large changes (2✅)
Medium changes (1🟥)
Small changes (2✅, 1🟥)
|
cbv ite/dite simprocs by reducing Decidable instance directly
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
…stance directly (#12677) This PR changes the approach in `simpIteCbv` and `simpDIteCbv`, by replacing call to `Decidable.decide` with reducing and direct pattern matching on the `Decidable` instance for `isTrue`/`isFalse`. This produces simpler proof terms. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the approach in
simpIteCbvandsimpDIteCbv, by replacing call toDecidable.decidewith reducing and direct pattern matching on the
Decidableinstance forisTrue/isFalse. This produces simpler proof terms.