fix: guard LSP refresh requests behind capability check#12735
Open
wvhulle wants to merge 1 commit intoleanprover:masterfrom
Open
fix: guard LSP refresh requests behind capability check#12735wvhulle wants to merge 1 commit intoleanprover:masterfrom
wvhulle wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR guards diagnostic refresh requests behind capability checking so editors that don't advertise refresh support don't receive unsolicited requests.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Author
|
@wkrozowski I rebased on latest master but the bot still shows the message. Why is that? |
wvhulle
changed the title
wkrozowski
changed the title
wkrozowski
added
changelog-server
Contributor
|
@mhuisi Marc, could you have a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes repeated spamming of LSP clients with responses the client never advertised in its set of capabilities.
May close: #7488