fix: spurious unused variable warnings#790
Merged
david-christiansen merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Fixes an issue where variables in Lean code blocks would trigger spurious unused variable warnings. The issue happens because the unused variable linter inspects info trees. With embedded Lean blocks, it runs twice: once for the embedded code, and again on the Verso command. The second time around, the Verso syntax doesn't match the ignore functions, so it triggers spurious warnings. This bug was previously masked by the source span issue that was fixed in #700.
Contributor
|
Preview for this PR is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where variables in Lean code blocks would trigger spurious unused variable warnings.
The issue happens because the unused variable linter inspects info trees. With embedded Lean blocks, it runs twice: once for the embedded code, and again on the Verso command. The second time around, the Verso syntax doesn't match the ignore functions, so it triggers spurious warnings.
This bug was previously masked by the source span issue that was fixed in #700.