add warning for unused v4 input features#104
Merged
jerrylin96 merged 1 commit intoleap-stc:mainfrom Feb 3, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
========================================
- Coverage 6.72% 6.41% -0.32%
========================================
Files 1 1
Lines 847 982 +135
========================================
+ Hits 57 63 +6
- Misses 790 919 +129 ☔ View full report in Codecov by Sentry. |
jerrylin96
approved these changes
Feb 3, 2025
Collaborator
jerrylin96
left a comment
jerrylin96
left a comment
There was a problem hiding this comment.
Thanks Zeyuan! Adding this to climsim3 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a clarification in the online testing section that previous step's scalar features and location index should not be used in training, since they are not supported in E3SM implementation yet.