-
Notifications
You must be signed in to change notification settings - Fork 6
Community contribution label #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community contribution label #14
Conversation
|
Thank you, @iamshobhraj, we will review. Following-up on your comment
I think this @rtibbles's guidance from another pull request should be relevant
|
|
@MisRob i added the tidbex token generation, but i dont know if the token generated will have the permissions needed to add label to issues and read collaborators from the repository. |
|
Thanks @iamshobhraj, we will test that and follow-up |
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iamshobhraj, thanks a lot! I reviewed as best as I could and left few minor notes. Overall it looks very well to me. I will now invite @rtibbles whose skills with actions and Python are much better than mine. After he confirms it's good to go, we will merge and I will test it in our environment.
| if action == "assigned" and has_external_assignee: | ||
| add_label(owner, repo_name, issue_number, token) | ||
| elif action == "unassigned" and not has_external_assignee: | ||
| remove_label(owner, repo_name, issue_number, token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I appreciated that you thought of looping all assigneess, and removing the label only when none of them is external.
|
@MisRob Thanks for reviewing the pr, I have made the changes you requested. |
rtibbles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tweaks - mostly to make sure we're not running this unnecessarily or setting it up wrongly in other repos.
rtibbles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go to me.
|
Thank you @iamshobhraj. I will merge now and spend some time testing via |
Description
Add GitHub Actions workflow to automatically manage the "community-contribution-in-progress" label on issues based on external contributor assignments. This PR adds both the workflow configuration and the label management script.
Issue addressed
Addresses learningequality/kolibri#12923
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
This PR adds:
community-contribution-label.yml)community-contribution-label.py)The workflow:
The script:
Testing checklist
Reviewer guidance
After review
CHANGELOG.mdComments