Updated github workflow to ignore bot comments #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
reviewed
Mar 11, 2025
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Thanks @Sanchit-100, this seems like the correct change to me. @rtibbles Does it look okay to you? I should be able to test it during testing #18 since that action sends us notifications with LE bot.
rtibbles
approved these changes
Mar 17, 2025
Member
|
I will merge @Sanchit-100 and take some time to test. Will close the issue but it's possible I will follow-up here in case some tweaks will be needed. Thanks a lot! |
Member
|
@Sanchit-100 few first test runs done and all looks good so far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #12568 by updating the notify_team_new_comment.yml GitHub Actions workflow. The enhancement ensures that Slack notifications are sent only for comments made by external contributors, effectively excluding specific bot users and repository members.
Changelog
Conditional Logic Update:
Modified the if condition in the contributor_issue_comment job to exclude comments from:
Specific bots ("sentry-io[bot]", "learning-equality-bot[bot]")
Testing Done
Validated the conditional logic to ensure only external contributor comments trigger Slack notifications.