Review cleanup: align positioning, harden travel map, tidy components#10
Merged
Conversation
Code-review follow-ups across the site:
- cv: general /cv headline + Profile opener to "Senior Software Engineer"
(was "Senior Backend Engineer", a copy-paste leftover from cv_backend)
- cv_backend: rewrite stack-flexibility line concisely
("Strongest in Ruby, fluent in Python / JavaScript, quick to pick up any new stack")
- seo: realign SITE_DESCRIPTION, JSON-LD Person description, and llms.txt
with the de-Web3 SaaS/stack-range framing the CVs already moved to
- cv: obfuscate exposed email to ilya0lebedev[at]gmail.com on all 4 variants
- travel: build-time guard that fails loudly if a visited country lacks a
numeric ISO id in countryIdsByCode (was a silent drop off the overlay)
- cleanup: delete unused Card.astro and HorizontalShopItem.astro
- docs: README DaisyUI v4 -> v5
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for grand-croquembouche-1d568d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a code review of the current site. No behavioural/UX changes; build and
astro checkare green.Changes
/cvheadline and Profile opener now say Senior Software Engineer (was "Senior Backend Engineer", a copy-paste leftover from the backend variant).cv_backendstack-flexibility line rewritten concisely: "Strongest in Ruby, fluent in Python / JavaScript, quick to pick up any new stack."SITE_DESCRIPTION, the JSON-LDPersondescription, andllms.txtnow match the de-Web3 SaaS / stack-range / AI-hands-on framing the CV pages already moved to (they previously still led with "Web3 infrastructure" / Arbitrum / Node NFTs).ilya0lebedev@gmail.comreplaced withilya0lebedev[at]gmail.comon all four CV variants.WorldTravelMapnow throws at build time if a visited country has no numeric ISO id incountryIdsByCode, instead of silently dropping it from the overlay.Card.astroandHorizontalShopItem.astro(the latter orphaned when the store pages were deleted).Verification
npx astro check— 0 errors, 0 warningsnpm run build— succeeds, 8 pages built🤖 Generated with Claude Code