Skip to content

[codex] improve reliability, testability, and interactive flow#11

Merged
leonardomso merged 4 commits into
masterfrom
codex/interactive-lint-cleanup
Apr 13, 2026
Merged

[codex] improve reliability, testability, and interactive flow#11
leonardomso merged 4 commits into
masterfrom
codex/interactive-lint-cleanup

Conversation

@leonardomso

Copy link
Copy Markdown
Owner

What changed

This PR improves Gone's reliability, testability, and command-path consistency.

  • refactors check, fix, and now interactive toward thin Cobra entrypoints with runner-style execution
  • expands direct command, UI, and integration coverage
  • adds end-to-end benchmark fixtures and harnesses
  • adopts pond/conc in parser and checker concurrency paths
  • aligns interactive mode with configured checker options instead of defaulting silently
  • clears the repository lint backlog so golangci-lint run ./... is actionable again

Why

The CLI had uneven architecture across commands, limited direct command coverage, and a noisy lint baseline that made quality regressions harder to detect. The interactive path also diverged from check/fix behavior by bypassing injected dependencies and checker configuration.

User impact

  • CLI behavior stays compatible, but command internals are easier to test and maintain
  • interactive mode now respects configured checker settings more consistently
  • CI quality gates are stronger: lint, tests, race checks, and integration coverage are all green
  • benchmark fixtures are now available for measuring future performance work before hot-path refactors land

Validation

  • golangci-lint run ./...
  • go test ./...
  • go test -race ./...
  • go test -tags=integration ./cmd
  • go test -run '^$' -bench 'BenchmarkPipeline_' ./cmd -benchtime=1x

Add command-level integration and fuzz coverage across parser flows.
Fix config-driven structured output when no links are found or all links are ignored.
Fix redirect auto-fixes for duplicate URLs across files and make filter tracking race-safe.
Refactor check and fix into injected runners, expand command and UI tests, add end-to-end benchmarks and fixtures, and adopt pond/conc in checker and parser hot paths.
Route interactive through an injected runner, pass configured checker options into the UI path, and clear the repository lint backlog while keeping tests and integration coverage green.
@leonardomso leonardomso marked this pull request as ready for review April 13, 2026 06:33
@leonardomso leonardomso merged commit 186725f into master Apr 13, 2026
2 checks passed
@leonardomso leonardomso deleted the codex/interactive-lint-cleanup branch April 13, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant